Skip to content

Validation#651

Merged
fneum merged 133 commits intomasterfrom
validation
Aug 6, 2023
Merged

Validation#651
fneum merged 133 commits intomasterfrom
validation

Conversation

@FabianHofmann
Copy link
Copy Markdown
Contributor

@FabianHofmann FabianHofmann commented Apr 25, 2023 •
edited by fneum
Loading

closes #363
closes #462
closes #523

ToDos

  • Rename config.validation.yaml in Snakefile to config.yaml
  • Re-enable shipping raster
  • simple hydro constraint (p_min_pu and/or p_max_pu (per country))
  • start up cost update
  • check the efficiencies of polish coal fleet
  • crossborder code (direction, orders of magnitude)
  • solve electricity prices
  • historical dispatch as a outer constraint for nuclear
  • add a section to documentation

FabianHofmann and others added 30 commits April 25, 2023 14:44
@FabianHofmann
draft validation config for 2019
ddd472b
@lisazeyen
add switch for UC and linearized UC
c29da02
@lisazeyen
add UC function
9fc9476
@FabianHofmann
snakefile: use validation config
9f4f761
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2433c00 
for more information, see https://pre-commit.ci
@chrstphtrs
update link for OPSD retrieval to latest, adjust config settings
7bdb58f
@FabianHofmann
retrieve.smk: set electricity demand source to latest
8ecd0ef
@FabianHofmann
Merge branch 'master' into validation
8994561
@FabianHofmann
build_elec_demand: fix LU demand for 2019
5fd1b8a
@chrstphtrs
add Philipp's notebook, modify .gitignore to track notebooks
d405c32
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
aa5d4b0 
for more information, see https://pre-commit.ci
@lisazeyen
adjust cost year
c467b3a
@FabianHofmann
determine_cutout_xXyY: add docstring
630800f
@FabianHofmann
config: disable shipping raster
a88ea7a
@FabianHofmann
build_electricity_demand: add BA for 2019
9c37ecc
@FabianHofmann
fix unit_commitment function and file, add it to config.validation
e2119d6
@FabianHofmann
fix uc input file name
c2095ec
@FabianHofmann
update uc attributes
1a42b0c
@lisazeyen
bug fix uc constraint
9560797
@FabianHofmann
solve_network: fix UC
dcc7b4c
@FabianHofmann
solve_network: solve network fix kwargs
d962969
@lisazeyen
fix bug load shedding constraint
e6f0d8a
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9ae7a93 
for more information, see https://pre-commit.ci
@chrstphtrs
update entso-e data pull and clean
86e5a40
@chrstphtrs
Merge branch 'validation' of github.com:PyPSA/pypsa-eur into validation
b4d2569
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
94d41b2 
for more information, see https://pre-commit.ci
@FabianHofmann
do not cluster conventional gens, fix CO2 limit
9b39cdf
@lisazeyen
add emission price of 25eur/t
85e02c9
@FabianHofmann
fixup non-clustering of conventional generators
a6ae03d
@lisazeyen
not cluster conventionals
05d9331
@FabianHofmann FabianHofmann marked this pull request as ready for review August 1, 2023 07:40
@FabianHofmann FabianHofmann requested a review from fneum August 1, 2023 10:24
fneum
fneum reviewed Aug 1, 2023
View reviewed changes
fneum
fneum reviewed Aug 1, 2023
View reviewed changes
fneum
fneum reviewed Aug 1, 2023
View reviewed changes
fneum
fneum requested changes Aug 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fneum fneum left a comment •
edited by FabianHofmann
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few nice new features! I have a couple of suggestions:

  • are sources for added data files listed in documentation?

@FabianHofmann
Copy link
Copy Markdown
Contributor Author

FabianHofmann commented Aug 2, 2023

Thank you @fneum for the detailed review! @virio-andreyana will take over most of the points

@fneum
Copy link
Copy Markdown
Member

fneum commented Aug 5, 2023

Once CI goes through, good to go.

@fneum fneum enabled auto-merge August 6, 2023 07:22
@fneum fneum merged commit e34cec4 into master Aug 6, 2023
@fneum fneum deleted the validation branch August 6, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fneum fneum fneum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

@Roadmap
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document existing and planned validation Add rsync utility snakemake rules Validation of the Power System Model for 2019

6 participants

@FabianHofmann @lisazeyen @fneum @chrstphtrs @LukasFrankenQ @virio-andreyana