Skip to content

fix bugs in reserve constraint#645

Merged
fneum merged 4 commits intomasterfrom
fix-reserve-constraint
Apr 21, 2023
Merged

fix bugs in reserve constraint#645
fneum merged 4 commits intomasterfrom
fix-reserve-constraint

Conversation

@lisazeyen
Copy link
Copy Markdown
Contributor

@lisazeyen lisazeyen commented Apr 20, 2023

Closes # (if applicable).

Fix bugs in reserve constraint

This PR should fix to bugs in the operational reserve constraint.

  1. bug: when formulating the lhs of the constraint it is summed over the time steps not the generators
  2. bug: for the additional constraint that reserve + dispatch < capacity the sign is the wrong way around

This PR does not fix the issue that this constraint only works for the power sector.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

@lisazeyen lisazeyen requested a review from FabianHofmann April 20, 2023 07:39
Copy link
Copy Markdown
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would just suggest renaming the constraint.

rename constraint to fit to other syntax

Co-authored-by: Fabian Hofmann <[email protected]>
@lisazeyen lisazeyen enabled auto-merge April 20, 2023 07:56
@fneum fneum disabled auto-merge April 21, 2023 08:06
@fneum fneum merged commit 2baacfa into master Apr 21, 2023
@fneum fneum deleted the fix-reserve-constraint branch April 21, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants