#624 Rename build_load_data to build_electricity_demand#642
Merged
fneum merged 9 commits intoPyPSA:masterfrom Apr 19, 2023
Merged
Conversation
updates: - [github.com/PyCQA/docformatter: v1.5.1 → v1.6.0](PyCQA/docformatter@v1.5.1...v1.6.0) - [github.com/snakemake/snakefmt: v0.8.3 → v0.8.4](snakemake/snakefmt@v0.8.3...v0.8.4)
Signed-off-by: Ahmad <[email protected]>
fneum
requested changes
Apr 12, 2023
Member
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
@Ahmad-Wahid, cheers for this contribution!
There are a few more references to build_load_data in the repository (e.g. in the documentation). Could you change that to build_electricity_demand, too?
[pre-commit.ci] pre-commit autoupdate
Contributor
Author
|
sure, I will update that. |
Signed-off-by: Ahmad <[email protected]>
…lectricity_demand' into rename_build_load_data_2_build_electricity_demand
Signed-off-by: Ahmad <[email protected]>
Contributor
Author
|
@fneum hey I'm not sure about this pre-commit.ci thing. It's failed. would you tell that how can I fix it? I'm still new to git |
fneum
requested changes
Apr 15, 2023
Member
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
You don't need to worry about the pre-commit. It's likely because of the version update of docformatter.
There are 3 more references to build_load_data that should be adapted:
- doc/preparation.rst
- doc/release_notes.rst
- scripts/build_electricity_demand.py -> mock_snakemake
Could you also add a release note in doc/release_notes.rst mentioning the renaming?
Then, we're good to merge.
- added a released note about the renaming of build_load_data to build_electricity_demand
fneum
approved these changes
Apr 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #624
Changes proposed in this Pull Request