Skip to content

Multi horizon#637

Merged
FabianHofmann merged 77 commits intomasterfrom
multi-horizon
Oct 5, 2023
Merged

Multi horizon#637
FabianHofmann merged 77 commits intomasterfrom
multi-horizon

Conversation

@lisazeyen
Copy link
Copy Markdown
Contributor

@lisazeyen lisazeyen commented Apr 6, 2023 •
edited by fneum
Loading

Closes # (if applicable).

Changes proposed in this Pull Request

This PR should include perfect foresight for pathway optimisation.

Open ToDos:

  • add extra_functionalities for perfect foresight
  • min_part_load for methanolisation for shipping and Fischer-Tropsch leads to infeasibilities
  • must run condition for existing gas boilers to avoid massive back up energy, add option to retrofit them to h2 boilers
  • transmission expansion
  • carbon budget constraint
  • option for max growth for certain carriers

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

lisazeyen and others added 19 commits April 3, 2023 16:09
@lisazeyen
add rules for perfect foresight
e5e7d5f
@lisazeyen
add lifetimes for perfect
00544ee
@lisazeyen
add scripts for perfect foresight
952a6ba
@lisazeyen
adjust to new pypsa-eur syntax
247c504
@lisazeyen
Merge remote-tracking branch 'origin' into perfect
57ef5cd
@lisazeyen
always add load shedding with 1e2
d836970
@lisazeyen
remove slash
b9c58db
@lisazeyen
remove snakemake from function
b50954a
@lisazeyen
remove more /
87135fd
@lisazeyen
add eea co2 emissions as input
461ea66
@lisazeyen
fix plot bugs
f2ff8be
@lisazeyen
adjust summary functions
5989c28
@lisazeyen
add multi-deacde
f0d6d2b
@lisazeyen
add social discount rate
c1cced4
@lisazeyen
remove output capital cost
1a7e9c2
@lisazeyen
adjust plotting
91d2a4a
@lisazeyen
add global constraints in concat, adjust bio stores
a72a620
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5f554ab 
for more information, see https://pre-commit.ci
@lisazeyen
merge master
5c90083
@fneum fneum mentioned this pull request Jul 26, 2023
Closed
@lisazeyen lisazeyen marked this pull request as ready for review August 30, 2023 10:07
@lisazeyen
Copy link
Copy Markdown
Contributor Author

lisazeyen commented Aug 31, 2023

@FabianHofmann Some points still can be improved for the multi-decade optimisation, but I would be happy to pull a first beta version into the master branch and then work on the single features in separate smaller PR.

@lisazeyen
Copy link
Copy Markdown
Contributor Author

lisazeyen commented Sep 5, 2023

@FabianHofmann CI should run through once PyPSA/PyPSA#721 is in. There is a problem if the optimisation is multi-decade and the list of extendable lines or DC links is empty when selecting the active assets of an empty list.

@lisazeyen
Copy link
Copy Markdown
Contributor Author

lisazeyen commented Sep 29, 2023

@FabianHofmann, what do you think, can we merge?

FabianHofmann
FabianHofmann reviewed Sep 29, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be much in favour to merge it. Here some last remaining comments and the CI should run through. Otherwise, it looks great!

@lisazeyen
Copy link
Copy Markdown
Contributor Author

lisazeyen commented Oct 4, 2023 •
edited
Loading

@FabianHofmann thanks for your feedack!
CI is running through with the latest PyPSA Version, only the building of the documentation fails. I addressed your points above

@FabianHofmann
Copy link
Copy Markdown
Contributor

FabianHofmann commented Oct 5, 2023

Nice, let's go for it!

@FabianHofmann FabianHofmann merged commit 9cc6761 into master Oct 5, 2023
@FabianHofmann FabianHofmann deleted the multi-horizon branch October 5, 2023 10:34
fneum added a commit that referenced this pull request Oct 8, 2023
@fneum
follow-up to #637: remove duplicate code and update tsam version
679d09c
@fneum fneum mentioned this pull request Oct 8, 2023
Closed
fneum added a commit that referenced this pull request Oct 18, 2023
@fneum
Merge pull request #748 from PyPSA/follow-up-637
7884392 
follow-up to #637: remove duplicate code and update tsam version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianHofmann FabianHofmann FabianHofmann left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lisazeyen @FabianHofmann