use ship raster tif file directly instead of converted nc file#476
Closed
FabianHofmann wants to merge 2 commits intomasterfrom
Closed
use ship raster tif file directly instead of converted nc file#476FabianHofmann wants to merge 2 commits intomasterfrom
FabianHofmann wants to merge 2 commits intomasterfrom
Conversation
Member
|
The build shapes script is no longer necessary, is it? Has this been tested for functionality and performance degression already? |
Member
|
Hmm, I think we shouldn't skip cutting to the geographical scope of the model. The extracted |
Contributor
Author
|
Did you see large differences? Performance wise it was just a couple of seconds for me and memory use was also not high. Alternatively we could clip the tif file before writing to file. |
Member
|
I’d definitely clip it. I am more worried about the 10 GB of disk space than little higher memory usage. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #474
Checklist
envs/environment.yamlandenvs/environment.docs.yaml.config.default.yaml,config.tutorial.yaml, andtest/config.test1.yaml.doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes.