fill cost calues with default after merging custom costs#1911
Merged
fill cost calues with default after merging custom costs#1911
Conversation
Member
Author
lkstrp
approved these changes
Nov 25, 2025
toniseibold
pushed a commit
that referenced
this pull request
Dec 1, 2025
daniel-rdt
pushed a commit
to open-energy-transition/open-tyndp
that referenced
this pull request
Dec 8, 2025
* ci: free up disk space (PyPSA#1920) * fill cost values with defaults after merging custom costs (PyPSA#1911) * chore: set ptes.dynamic_capacity default to false (PyPSA#1924) * flip sector:district_heating:ptes:dynamic_capacity:true to false * update release notes * add pixi files and data folder to .sync-send (PyPSA#1923) * Bugfix load shedding scaling (PyPSA#1908) * Fix bugs by (i) removing sign argument and (ii) using isinstance * Remove todo and color and nice_name assignment. * Add release notes. * Change p_nom_extendable=True to p_nom=np.inf * Updated doctables for load_shedding * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Co-authored-by: Lukas Trippe <[email protected]> Co-authored-by: Martha Frysztacki <[email protected]> Co-authored-by: Amos Schledorn <[email protected]> Co-authored-by: Fabian Neumann <[email protected]> Co-authored-by: jonathan-peel <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Currently cost values are filled with default values before merging them with the (raw) custom cost data. If the custom cost data however includes new technologies but misses, for example, the discount rates, the prepared results such as
capital_costremain missing /NaN.I suggest changing the order.
It's not necessary for the
custom_preparedstep, because this is either a result or given (so it's filled either way).Checklist
pixi.toml(usingpixi add <dependency-name>).config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.