Skip to content

Fix clean-tests section in pixi.toml#1901

Merged
lkstrp merged 2 commits intomasterfrom
fix-pixi-task-clean-tests
Nov 17, 2025
Merged

Fix clean-tests section in pixi.toml#1901
lkstrp merged 2 commits intomasterfrom
fix-pixi-task-clean-tests

Conversation

@euronion
Copy link
Copy Markdown
Contributor

@euronion euronion commented Nov 14, 2025

Follow up to #1886 . clean-tests task was not working because of surplus ||. And I think they are meant to be && instead.

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to pixi.toml (using pixi add <dependency-name>).
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@euronion euronion requested a review from lkstrp November 14, 2025 13:36
lkstrp
lkstrp reviewed Nov 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should rather be ; instead of || to always run all clean up commands, no matter if all succeed

@euronion
Copy link
Copy Markdown
Contributor Author

euronion commented Nov 17, 2025

I think it should rather be ; instead of || to always run all clean up commands, no matter if all succeed

Works for me as well, as long as we fix the surplus ||

@lkstrp lkstrp merged commit fd146fd into master Nov 17, 2025
6 of 8 checks passed
@lkstrp lkstrp deleted the fix-pixi-task-clean-tests branch November 17, 2025 08:34
@coroa
Copy link
Copy Markdown
Member

coroa commented Nov 17, 2025

Agree for the ;. || means: only run the next step, when the previous one failed.

@brynpickering
Copy link
Copy Markdown
Contributor

brynpickering commented Nov 17, 2025

My bad, should have used ; from the start...

toniseibold pushed a commit that referenced this pull request Dec 1, 2025
@euronion @toniseibold
Fix clean-tests section in pixi.toml (#1901)
1cd0869 
* Fix clean-tests section in pixi.toml

* code: Always run cleanup tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkstrp lkstrp lkstrp left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@euronion @coroa @brynpickering @lkstrp