refactor: remove hotfix and check that the directory exists#1840
Merged
fneum merged 8 commits intoPyPSA:masterfrom Nov 19, 2025
Merged
refactor: remove hotfix and check that the directory exists#1840fneum merged 8 commits intoPyPSA:masterfrom
fneum merged 8 commits intoPyPSA:masterfrom
Conversation
coroa
approved these changes
Oct 27, 2025
fneum
approved these changes
Nov 1, 2025
Member
fneum
left a comment
fneum
left a comment
There was a problem hiding this comment.
Thanks! No objections, merge at will once CI passes.
4 tasks
toniseibold
pushed a commit
that referenced
this pull request
Dec 1, 2025
* refactor: remove hotfix and check that the directory exists * doc: add release note * refactor: use streaming copy instead of loading into memory --------- Co-authored-by: Fabian Neumann <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
This PR removes the hotfix in
progress_retrieveand checks that the directory exists. I tested it with the latest env in the master forrun:disable_progressbarwith bothtrueandfalse. I wasn't able to reproduce the bug introduced in 54e39df in the first place.Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.