Skip to content

Bugfix grid valueerror#1780

Merged
fneum merged 30 commits intoPyPSA:masterfrom
jonathan-peel:bugfix-grid-valueerror
Aug 21, 2025
Merged

Bugfix grid valueerror#1780
fneum merged 30 commits intoPyPSA:masterfrom
jonathan-peel:bugfix-grid-valueerror

Conversation

@jonathan-peel
Copy link
Copy Markdown
Contributor

Closes #1777 .

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Copy link
Copy Markdown
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (perhaps worth cherry-picking to disentangle from #1768)

@jonathan-peel jonathan-peel force-pushed the bugfix-grid-valueerror branch from fc435a8 to db86e70 Compare August 21, 2025 13:15
@jonathan-peel jonathan-peel force-pushed the bugfix-grid-valueerror branch from db86e70 to 3a857f2 Compare August 21, 2025 13:28
@jonathan-peel
Copy link
Copy Markdown
Contributor Author

Branch rebased for clean commit history.

@fneum fneum merged commit 7385364 into PyPSA:master Aug 21, 2025
6 of 7 checks passed
@jonathan-peel jonathan-peel deleted the bugfix-grid-valueerror branch August 21, 2025 16:22
measrainsey pushed a commit to open-energy-transition/pypsa-wal that referenced this pull request Sep 5, 2025
* Fix FileNotFoundError for rule retrieve_eez

* Fix FileNotFoundError for rule retrieve_nuts_2021_shapes

* Update zip -> zip_file; change to shcopy2

* Fix FileNotFoundError for rule retrieve_nuts_2013_shapes

* Fix FileNotFoundError in rule retrieve_worldbank_urban_population

* Fixed FileNotFoundError in rule retrieve_co2stop

* Fix FileNotFoundError for rule download_wdpa

* Fix FileNotFoundError for rule download_wdpa_marine

* Change zip to zip_file in rule retrieve_aquifer_data_bgr

* Remove unnecessary imports

* Add release note

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add link to pull request

* Fix FileNotFoundError for rule retrieve_eurostat_data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove shadow directory from rule retrieve_eurostat_data

* Add tempory file handling for rule retrieve_eurostat_data

* Fix FileNotFoundError for rule retrieve_eurostat_household_data
Also add management for temporary tarball file

* Update release notes

* Replace shadow directories with manual file deletion.

* Update release notes.

* Removed chmod for windows compatability.

* Fix AttributeError in prepare_sector_network.py

* Update release notes

* Update release notes to include link to pull request.

* Fix ValueError in function add_storage_and_grids of prepare_sector_network.py

* Add release notes

* Update release notes to include link to pull request.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Fabian Neumann <[email protected]>
toniseibold pushed a commit that referenced this pull request Dec 1, 2025
* Fix FileNotFoundError for rule retrieve_eez

* Fix FileNotFoundError for rule retrieve_nuts_2021_shapes

* Update zip -> zip_file; change to shcopy2

* Fix FileNotFoundError for rule retrieve_nuts_2013_shapes

* Fix FileNotFoundError in rule retrieve_worldbank_urban_population

* Fixed FileNotFoundError in rule retrieve_co2stop

* Fix FileNotFoundError for rule download_wdpa

* Fix FileNotFoundError for rule download_wdpa_marine

* Change zip to zip_file in rule retrieve_aquifer_data_bgr

* Remove unnecessary imports

* Add release note

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add link to pull request

* Fix FileNotFoundError for rule retrieve_eurostat_data

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove shadow directory from rule retrieve_eurostat_data

* Add tempory file handling for rule retrieve_eurostat_data

* Fix FileNotFoundError for rule retrieve_eurostat_household_data
Also add management for temporary tarball file

* Update release notes

* Replace shadow directories with manual file deletion.

* Update release notes.

* Removed chmod for windows compatability.

* Fix AttributeError in prepare_sector_network.py

* Update release notes

* Update release notes to include link to pull request.

* Fix ValueError in function add_storage_and_grids of prepare_sector_network.py

* Add release notes

* Update release notes to include link to pull request.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Fabian Neumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValueError in add_storage_and_grids function of prepare_sector_network.py when existing gas network already connects all nodes

2 participants