Conversation
|
It kind of conflicts with the purge rule which deletes resources and results folders. If we go ahead with this, the purge rule should be adjusted to delete the content of resources and results directories (rather than directories themselves). |
lkstrp
left a comment
lkstrp
left a comment
There was a problem hiding this comment.
I am a bit against .gitkeeps files, since they indicate git functionality when they are just random files. They also just hide the information if a directory actually contains anything.
Is there any other benefit then just for reference in the documentation? We could use a simple file tree instead. It's more clear anyway
|
There are some minor benefits (like tab completion for the folders) and downsides (like how the folders show up in the editor (w/ content and w/o content). It also makes creating the file trees easier - you don't need to manually edit them to add those folders. My main concern was them "popping up". From my experience, this behaviour can be a bit surprising for people that are not used to Happy to adjust the |
|
I don't have a strong preference on this matter. @euronion, if you'd like, go ahead and adjust the purge rule. |
|
I opted for the simple approach of recreating the folder with the |
|
@lkstrp Can we merge without CI? |
* code: Add empty folders to repo * Update purge rule --------- Co-authored-by: Fabian Neumann <[email protected]>
3 participants
I added the folders that will be automatically created by
snakemakeas empty folders with.gitkeep.The idea is to avoid folder "popping up" when exeucting the workflow. It also makes it easier to talk about those folders in the documentation, because one doesn't always have to add "this folder will be created automatically".
Changes proposed in this Pull Request
Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.