Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for setting up SARAH-based cutouts in atlite and fixes a typo in the existing features description.
- Fixed typo in the
featuresparameter description (inlfux→influx). - Added a new
sarah_dirparameter to the atlite configuration table. - Updated
config/config.default.yamlwith commented placeholders forfeaturesandsarah_dir.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/configtables/atlite.csv | Correct typo in features description and add sarah_dir parameter documentation. |
| config/config.default.yaml | Insert commented placeholders for the new features and sarah_dir options. |
Comments suppressed due to low confidence (3)
doc/configtables/atlite.csv:15
- [nitpick] Consider adding a concrete example in the CSV
examplecolumn (e.g.,/path/to/sarah_data) to clarify the expected format ofsarah_dir.
-- -- sarah_dir,,str,"Path to the location where SARAH-2 or SARAH-3 data is stored; SARAH data requires a manual separate download, see the https://atlite.readthedocs.io for details. Required for building cutouts with SARAH, not required for ERA5 cutouts."
config/config.default.yaml:147
- A new
sarah_diroption has been introduced but there are no tests covering SARAH-based cutout creation; consider adding unit tests to verify thatsarah_diris correctly parsed and used.
# sarah_dir: ""
config/config.default.yaml:146
- [nitpick] Commented config placeholders may drift out of sync—consider integrating these defaults into the schema or auto-generating them from
doc/configtables/atlite.csvto reduce duplication.
# features: []
fneum
approved these changes
Jul 6, 2025
toniseibold
pushed a commit
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.