fix: Correct DAG generation to respect all configuration sources#1678
Merged
fneum merged 3 commits intoPyPSA:masterfrom May 25, 2025
Merged
fix: Correct DAG generation to respect all configuration sources#1678fneum merged 3 commits intoPyPSA:masterfrom
fneum merged 3 commits intoPyPSA:masterfrom
Conversation
Ensures `rulegraph` and `filegraph` accurately reflect the final merged configuration. This includes: - Command-line config files (--configfile option) - Command-line config overrides (--config key=value) - Default config files loaded in the Snakefile Previously, these rules could produce misleading visualizations if command-line configurations were used, as they did not fully account for these overrides and sources. Technical Implementation: - Added `dump_graph_config` rule to capture the final Snakemake config. - Updated `rulegraph` and `filegraph` to use this captured config. - Added SVG output format for DAGs. - Enhanced error handling and logging in graph generation rules. docs: Updated release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures
rulegraphandfilegraphaccurately reflect the final merged configuration. This includes:Previously, these rules could produce misleading visualizations if command-line configurations were used, as they did not fully account for these overrides and sources.
Technical Implementation:
dump_graph_configrule to capture the final Snakemake config.rulegraphandfilegraphto use this captured config.docs: Updated release notes.
Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.