Skip to content

Revert "docs: remove -call argument (#1386)"#1650

Merged
lkstrp merged 4 commits intoPyPSA:masterfrom
tgilon:fix/revert-call
Apr 21, 2025
Merged

Revert "docs: remove -call argument (#1386)"#1650
lkstrp merged 4 commits intoPyPSA:masterfrom
tgilon:fix/revert-call

Conversation

@tgilon
Copy link
Copy Markdown
Collaborator

@tgilon tgilon commented Apr 21, 2025 •
edited
Loading

This reverts commit 225dae0, PR #1386.

Changes proposed in this Pull Request

As of snakemake>=9.2.0 (changelog), the default behaviour of -cores for snakemake is restored. This PR suggests reverting the changes and updates the environment.

From snakemake changelog:

restore accidentally changed behavior of –cores. If not specified, Snakemake now complains again, asking for –cores to be specified (of –jobs in case of remote exec). As before, if a default is desired, it can be easily set via a profile (#3531) (11b2b30)

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@tgilon tgilon marked this pull request as ready for review April 21, 2025 08:46
@tgilon tgilon requested a review from lkstrp April 21, 2025 08:46
lkstrp
lkstrp reviewed Apr 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But --cores is not the same as --call?

The issue with --cores you are mentioning has been addressed in #1647, but is not merged yet

@tgilon
Copy link
Copy Markdown
Collaborator Author

tgilon commented Apr 21, 2025

Did I missed smth? As far as I know -call is the contraction of --cores all.

But correct, I missed your PR. It might be good to update more than just the Makefile.

@lkstrp
Copy link
Copy Markdown
Member

lkstrp commented Apr 21, 2025

Ahh, no, I missed something. -call wasn't in the docs when I searched for it, but I didn't make the connection with the contraction of --cores all either. Which makes much sense. Then this PR is much better, thank you!

lkstrp
lkstrp reviewed Apr 21, 2025
View reviewed changes
@lkstrp lkstrp merged commit 7ea6a1e into PyPSA:master Apr 21, 2025
12 checks passed
@lkstrp lkstrp mentioned this pull request Apr 21, 2025
Closed
@tgilon tgilon deleted the fix/revert-call branch April 21, 2025 11:15
@tgilon tgilon mentioned this pull request Apr 23, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkstrp lkstrp lkstrp left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgilon @lkstrp