Skip to content

Add test for build powerplants#1432

Merged
lkstrp merged 11 commits intoPyPSA:masterfrom
finozzifa:add_test_build_powerplants
Nov 22, 2024
Merged

Add test for build powerplants#1432
lkstrp merged 11 commits intoPyPSA:masterfrom
finozzifa:add_test_build_powerplants

Conversation

@finozzifa
Copy link
Copy Markdown
Collaborator

@finozzifa finozzifa commented Nov 20, 2024

Closes # (if applicable).

Changes proposed in this Pull Request

The pull request proposes the following unit tests:

test/test_build_powerplants.py:

  • test_add_custom_powerplants
  • test_replace_natural_gas_technology
  • test_replace_natural_gas_fueltype

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@finozzifa finozzifa marked this pull request as ready for review November 22, 2024 11:23
Copy link
Copy Markdown
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, a great start of a long journey for unit testing in pypsa-eur. Thanks @finozzifa!
Just a few small things. I'm also not sure if there's a better way to get test data, but I think it's fine.

@lkstrp lkstrp merged commit 17628e9 into PyPSA:master Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants