Skip to content

Add minor fix#1419

Merged
lkstrp merged 1 commit intoPyPSA:masterfrom
davide-f:minor_fixes
Nov 12, 2024
Merged

Add minor fix#1419
lkstrp merged 1 commit intoPyPSA:masterfrom
davide-f:minor_fixes

Conversation

@davide-f
Copy link
Copy Markdown
Contributor

@davide-f davide-f commented Nov 11, 2024 •
edited
Loading

Closes # (if applicable).

Changes proposed in this Pull Request

There are 3 redundant lines in the geothermal modelling.
These lines change the efficiency of the link but the same efficiency is already specified see:

pypsa-eur/scripts/prepare_sector_network.py

Lines 4463 to 4473 in 2e07e82

n.add(
"Link",
bus + " geothermal organic rankine cycle",
bus0=f"{bus} geothermal heat surface",
bus1=bus,
p_nom_extendable=True,
carrier="geothermal organic rankine cycle",
capital_cost=orc_capital_cost * efficiency_orc,
efficiency=efficiency_orc,
lifetime=costs.at["organic rankine cycle", "lifetime"],
)

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

lkstrp
lkstrp approved these changes Nov 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davide-f !

@lkstrp lkstrp merged commit ac57afa into PyPSA:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lkstrp lkstrp lkstrp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davide-f @lkstrp