Skip to content

Correct bioliquid emissions by BtL efficiency#1410

Merged
lindnemi merged 3 commits intomasterfrom
correct_bioliquid_emissions
Nov 6, 2024
Merged

Correct bioliquid emissions by BtL efficiency#1410
lindnemi merged 3 commits intomasterfrom
correct_bioliquid_emissions

Conversation

@cpschau
Copy link
Copy Markdown
Contributor

@cpschau cpschau commented Nov 6, 2024 •
edited
Loading

Changes proposed in this Pull Request

In prepare_sector_network the link between unsustainable bioliquids and oil previously did not correctly account for the amount of CO₂ emissions withdrawn from the atmosphere. The efficiency value was directly copied from the BtL (biomass to liquid) link without adjusting for the primary efficiency value, which represents the conversion between solid biomass and oil.

With this updated efficiency, 0.248 MtCO₂ are withdrawn from the atmosphere per MWh of unsustainable bioliquids introduced into the system. However, there remains a discrepancy when compared to the CO₂ intensity of oil used in the model, which stands at 0.2571. This difference is consistent with the BtL link’s implementation. An alternative approach would be to adjust the efficiency value to match the exact CO₂ intensity of oil, thereby eliminating the gap.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
prices.csv ⚠️Changed 0.000 0.07
weighted_prices.csv ⚠️Changed 0.726 0.55
market_values.csv ⚠️Changed 0.000 0.09
price_statistics.csv ⚠️Changed 0.000 0.22
metrics.csv ⚠️Changed 0.000 0.08
cfs.csv ⚠️Changed 0.028 0.08
curtailment.csv ⚠️Changed 0.000 0.13
nodal_cfs.csv ✅ Almost equal 0.077 0.02
nodal_costs.csv ✅ Almost equal 0.003 0.00
nodal_capacities.csv ✅ Almost equal 0.000 0.00
supply.csv ✅ Almost equal 0.000 0.02
nodal_supply_energy.csv ✅ Almost equal 0.000 0.00
costs.csv ✅ Almost equal 0.000 0.01
capacities.csv ✅ Almost equal 0.000 0.03
supply_energy.csv ✅ Almost equal 0.000 0.03
energy.csv ✅ Almost equal 0.000 0.03

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing correct_bioliquid_emissions (a01eb01) with master (52b8179).
Branch is 3 commits ahead and 0 commits behind.
Last updated on 2024-11-06 15:16:16 CET.

@cpschau cpschau marked this pull request as ready for review November 6, 2024 10:29
@cpschau cpschau requested a review from lindnemi November 6, 2024 10:29
lindnemi
lindnemi reviewed Nov 6, 2024
View reviewed changes
@lindnemi
Copy link
Copy Markdown
Contributor

lindnemi commented Nov 6, 2024

@cpschau please add a release note, then it can be merged

@lindnemi lindnemi merged commit 92f0b2a into master Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindnemi lindnemi lindnemi left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cpschau @lindnemi