Skip to content

bugfix: only add waste chp to buses which have urban central heat buses#1407

Merged
p-glaum merged 4 commits intomasterfrom
bugfix/waste-heat-chp
Nov 7, 2024
Merged

bugfix: only add waste chp to buses which have urban central heat buses#1407
p-glaum merged 4 commits intomasterfrom
bugfix/waste-heat-chp

Conversation

@p-glaum
Copy link
Copy Markdown
Contributor

@p-glaum p-glaum commented Nov 4, 2024 •
edited
Loading

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@p-glaum p-glaum added the bug label Nov 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
market_values.csv ⚠️Changed 0.000 0.06
weighted_prices.csv ⚠️Changed 0.610 0.39
curtailment.csv ⚠️Changed 0.000 0.22
price_statistics.csv ⚠️Changed 0.001 0.14
metrics.csv ⚠️Changed 0.000 0.07
nodal_supply_energy.csv ✅ Almost equal 0.000 0.00
nodal_cfs.csv ✅ Almost equal 0.076 0.03
supply.csv ✅ Almost equal 0.000 0.02
nodal_costs.csv ✅ Almost equal 0.003 0.00
nodal_capacities.csv ✅ Almost equal 0.000 0.00
prices.csv ✅ Almost equal 0.000 0.02
capacities.csv ✅ Almost equal 0.000 0.03
costs.csv ✅ Almost equal 0.000 0.01
cfs.csv ✅ Almost equal 0.048 0.03
supply_energy.csv ✅ Almost equal 0.000 0.02
energy.csv ✅ Almost equal 0.000 0.02

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing bugfix/waste-heat-chp (4968e1f) with master (0c41cec).
Branch is 4 commits ahead and 0 commits behind.
Last updated on 2024-11-06 18:26:51 CET.

@p-glaum p-glaum mentioned this pull request Nov 4, 2024
Merged
7 tasks
fneum
fneum requested changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but could make sense to add WtE everywhere but keep bus2 empty when urban central heat is not available.

Good to go once tested it doesn't cause any infeasibilities.

@p-glaum
Copy link
Copy Markdown
Contributor Author

p-glaum commented Nov 4, 2024

yes, this would be a better approach, because co2 could be like AC nodes available for every location. For me considering all nodes and also non existing urban central heat nodes did not cause infeasibilities, just a warning that bus does not exist.

fneum
fneum approved these changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is better!

@p-glaum p-glaum merged commit 2119f4c into master Nov 7, 2024
@p-glaum p-glaum deleted the bugfix/waste-heat-chp branch November 7, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fneum fneum fneum approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@p-glaum @fneum