Skip to content

Updated to osm-network version 0.5#1387

Merged
fneum merged 5 commits intomasterfrom
osm-0.5-update
Nov 10, 2024
Merged

Updated to osm-network version 0.5#1387
fneum merged 5 commits intomasterfrom
osm-0.5-update

Conversation

@bobbyxng
Copy link
Copy Markdown
Collaborator

@bobbyxng bobbyxng commented Oct 23, 2024

Changes proposed in this Pull Request

Update osm base network from 0.4 to 0.5:

  • Exact locations of original substations and converter stations (interior point/Pole of Inaccessibility) are preserved
  • Clustering resolution improved from 5000 to 500 meters
  • Lines of same electric parameters are merged, if they cross a virtual bus (that is not a real substation)
  • Information from OSM relations are used, wherever applicable. To avoid doubling, members (ways) of the relation are dropped in the set of lines, accordingly
  • There are now unique transformers for each voltage level in each station. Transformers now have a nominal capacity, representing the maximum of line capacities connected to either side/bus of the transformer (n-0, nominal capacity)
  • Wherever applicable, OSM IDs are preserved and used in the index of the network components.

Validation:

  • Europe, at NUTS2 resolution (318 regions), electricity sector, clustered at 3-hourly resolution
  • osm-prebuilt v0.4 (left) and v0.5 (right)
    Screenshot from 2024-10-23 11-12-19

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@bobbyxng bobbyxng requested review from fneum and lkstrp October 23, 2024 11:34
@bobbyxng bobbyxng self-assigned this Oct 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2024 •
edited
Loading

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
prices.csv ⚠️Changed 0.000 0.13
weighted_prices.csv ⚠️Changed 0.623 0.43
curtailment.csv ⚠️Changed 0.000 0.24
price_statistics.csv ⚠️Changed 0.189 0.13
metrics.csv ⚠️Changed 0.001 0.07
nodal_costs.csv ⚠️ NaN mismatch
nodal_supply_energy.csv ⚠️ NaN mismatch
nodal_cfs.csv ⚠️ NaN mismatch
nodal_capacities.csv ⚠️ NaN mismatch
supply.csv ✅ Almost equal 0.000 0.03
market_values.csv ✅ Almost equal 0.139 0.02
capacities.csv ✅ Almost equal 0.001 0.01
costs.csv ✅ Almost equal 0.000 0.02
cfs.csv ✅ Almost equal 0.065 0.05
supply_energy.csv ✅ Almost equal 0.000 0.03
energy.csv ✅ Almost equal 0.000 0.03

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing osm-0.5-update (e1be160) with master (ef20ee8).
Branch is 5 commits ahead and 0 commits behind.
Last updated on 2024-10-25 10:24:26 CEST.

lindnemi
lindnemi reviewed Oct 24, 2024
View reviewed changes
lindnemi
lindnemi reviewed Oct 24, 2024
View reviewed changes
fneum
fneum approved these changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one clarification required.

@bobbyxng bobbyxng mentioned this pull request Nov 6, 2024
Merged
7 tasks
@fneum fneum merged commit cd90b18 into master Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fneum fneum fneum approved these changes

@lindnemi lindnemi lindnemi left review comments

@lkstrp lkstrp lkstrp approved these changes

Assignees

@bobbyxng bobbyxng

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bobbyxng @fneum @lindnemi @lkstrp