Major improvement to OSM-based electricity grid (e.g. using relations, preserving substation locations)#1384
Merged
Major improvement to OSM-based electricity grid (e.g. using relations, preserving substation locations)#1384
Conversation
…eating voltage-specific bus endings in stations.
7 tasks
Contributor
Validator ReportI am the Validator. Download all artifacts here. ❗ Run failed!Download 'logs' artifact to see more details.
Model Metrics Comparing |
fneum
reviewed
Nov 4, 2024
Member
fneum
left a comment
There was a problem hiding this comment.
I didn't check every line in detail, but the structure looks good and comparable to the previous version. I have a series of small comments that are easy to address:
Collaborator
Author
|
Docstrings added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Changes proposed in this Pull Request
build_osm_networkcompletely rewritten:Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.