Skip to content

build_transmission_project: fix bug which lead to duplicates#1360

Merged
lkstrp merged 4 commits intomasterfrom
pglaum/fix_duplicate_bug
Nov 1, 2024
Merged

build_transmission_project: fix bug which lead to duplicates#1360
lkstrp merged 4 commits intomasterfrom
pglaum/fix_duplicate_bug

Conversation

@p-glaum
Copy link
Copy Markdown
Contributor

@p-glaum p-glaum commented Oct 14, 2024 •
edited
Loading

Closes # (if applicable).

Changes proposed in this Pull Request

With this PR, we fix the bug that some lines were not dropped even though they were previously detected as duplicates.
E.g. the terminal showed the following duplicated;

WARNING:__main__:Found new lines similar to existing lines:
{'DC1': 'TYNDP2020_23', 'DC3': 'TYNDP2020_1', 'DC4': 'TYNDP2020_2'}

however, they were still existing after build_transmission_projects.

This is now fixed.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master passed! ✅
  • pglaum/fix_duplicate_bug failed in: no_logs_found

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing pglaum/fix_duplicate_bug (25f267e) with master (7e1a8d4).
Branch is 4 commits ahead and 0 commits behind.
Last updated on 2024-11-01 10:38:48 CET.

@p-glaum p-glaum requested a review from lindnemi November 1, 2024 08:56
lindnemi
lindnemi approved these changes Nov 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lindnemi lindnemi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and we've been using this fix in ariadne2 for two weeks. Duplicates were removed. Let's wait and see if the Validator runs through, then we can merge it

@p-glaum p-glaum force-pushed the pglaum/fix_duplicate_bug branch from bc5f22f to 25f267e Compare November 1, 2024 09:07
@lkstrp lkstrp merged commit 464c4cf into master Nov 1, 2024
@p-glaum p-glaum deleted the pglaum/fix_duplicate_bug branch November 1, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindnemi lindnemi lindnemi approved these changes

@lkstrp lkstrp lkstrp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@p-glaum @lindnemi @lkstrp