Skip to content

set s_max_pu to the value according to config#1323

Merged
fneum merged 1 commit intomasterfrom
bug_fix_s_max_pu
Sep 25, 2024
Merged

set s_max_pu to the value according to config#1323
fneum merged 1 commit intomasterfrom
bug_fix_s_max_pu

Conversation

@p-glaum
Copy link
Copy Markdown
Contributor

@p-glaum p-glaum commented Sep 24, 2024 •
edited
Loading

Closes #1276

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@p-glaum p-glaum mentioned this pull request Sep 24, 2024
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
nodal_capacities.csv ⚠️ NaN mismatch
nodal_supply_energy.csv ⚠️ NaN mismatch
nodal_costs.csv ⚠️ NaN mismatch
nodal_cfs.csv ⚠️ NaN mismatch
cfs.csv ✅ Almost equal 0.049 0.07
costs.csv ✅ Almost equal 0.001 0.01
price_statistics.csv ✅ Almost equal 0.008 0.18
curtailment.csv ✅ Almost equal 0.000 0.22
metrics.csv ✅ Almost equal 0.000 0.07
supply.csv ✅ Almost equal 0.000 0.02
capacities.csv ✅ Almost equal 0.000 0.03
energy.csv ✅ Almost equal 0.000 0.02
weighted_prices.csv ✅ Almost equal 0.302 0.38
supply_energy.csv ✅ Almost equal 0.000 0.02
prices.csv ✅ Almost equal 0.000 0.16
market_values.csv ✅ Almost equal 0.001 0.10

NRMSE: Normalized (min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized Data (min-max
Status Threshold: MAE (norm) > 0.05 and NRMSE > 2

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing bug_fix_s_max_pu (44f49e0) with master (0d1c36b).
Branch is 1 commits ahead and 1 commits behind.
Last updated on 2024-09-24 09:32:29 CEST.

@fneum fneum merged commit d4bad07 into master Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fneum fneum fneum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

s_max_pu = 1 for some lines despite default config of 0.7

2 participants

@p-glaum @fneum