Skip to content

prepare for new n.add#1316

Merged
lkstrp merged 2 commits intomasterfrom
madd-preparation
Sep 25, 2024
Merged

prepare for new n.add#1316
lkstrp merged 2 commits intomasterfrom
madd-preparation

Conversation

@lkstrp
Copy link
Copy Markdown
Member

@lkstrp lkstrp commented Sep 20, 2024

  • Adds some more explicit indexing inprepare_sector_network.py since non matching indices are not allowed with new PyPSA version
  • See feat: improved n.add PyPSA#896

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
nodal_capacities.csv ⚠️ NaN mismatch
nodal_supply_energy.csv ⚠️ NaN mismatch
nodal_costs.csv ⚠️ NaN mismatch
nodal_cfs.csv ⚠️ NaN mismatch
cfs.csv ✅ Almost equal 0.047 0.05
costs.csv ✅ Almost equal 0.001 0.01
price_statistics.csv ✅ Almost equal 0.008 0.14
curtailment.csv ✅ Almost equal 0.000 0.25
metrics.csv ✅ Almost equal 0.000 0.07
supply.csv ✅ Almost equal 0.000 0.02
capacities.csv ✅ Almost equal 0.000 0.03
energy.csv ✅ Almost equal 0.000 0.02
weighted_prices.csv ✅ Almost equal 0.698 0.55
supply_energy.csv ✅ Almost equal 0.000 0.02
prices.csv ✅ Almost equal 0.000 0.15
market_values.csv ✅ Almost equal 0.000 0.08

NRMSE: Normalized (min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized Data (min-max
Status Threshold: MAE (norm) > 0.05 and NRMSE > 2

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing madd-preparation (b4ec511) with master (0d1c36b).
Branch is 2 commits ahead and 10 commits behind.
Last updated on 2024-09-24 10:19:42 CEST.

fneum
fneum approved these changes Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@fneum fneum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! So the new n.add would throw a warning if indices or snapshots for time-varying data don't match?

What about switching from n.madd to n.add? That was also planned, right?

@lkstrp
Copy link
Copy Markdown
Member Author

lkstrp commented Sep 24, 2024

Looks good! So the new n.add would throw a warning if indices or snapshots for time-varying data don't match?

Error, not a warning. So the next pypsa release is breaking. Slightly, but breaking.

What about switching from n.madd to n.add? That was also planned, right?

Yes, but this will fail for pypsa<=30.2. So once we set the dependency here on pypsa>=31.0 we can replace all n.madd (and n.madd will just point to n.add with a Deprecation Warning`).

@lkstrp lkstrp merged commit 24e0ddd into master Sep 25, 2024
@lkstrp lkstrp deleted the madd-preparation branch November 25, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fneum fneum fneum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lkstrp @fneum