Fix industrial demand for ammonia when endogenously modelled#1312
Merged
fneum merged 2 commits intoPyPSA:masterfrom Sep 20, 2024
Merged
Fix industrial demand for ammonia when endogenously modelled#1312fneum merged 2 commits intoPyPSA:masterfrom
fneum merged 2 commits intoPyPSA:masterfrom
Conversation
added 2 commits
September 19, 2024 16:03
In calculating industrial energy demand today, demand for ammonia must be resolved into just "ammonia" when endogenously modelled, or into electricity and hydrogen if not.
Member
|
Great! I'll do a small follow-up so that tests for Windows and MacOS run through (the |
fneum
added a commit
that referenced
this pull request
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In calculating industrial energy demand today, demand for ammonia must be resolved into just "ammonia" when endogenously modelled, or into electricity and hydrogen if not. Before this fix, energy demand for ammonia was double-counted at current and near-term planning horizons when
sector['ammonia'] = True; both in terms of ammonia and in terms of electricity and hydrogen.While not incredibly large in magnitude, hydrogen demand at 2025 planning horizon was essentially double what it should have been before this fix.
Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.