Skip to content

Only add buses in specified countries#1308

Merged
fneum merged 2 commits intoPyPSA:masterfrom
koen-vg:filter-buses-to-countries
Sep 18, 2024
Merged

Only add buses in specified countries#1308
fneum merged 2 commits intoPyPSA:masterfrom
koen-vg:filter-buses-to-countries

Conversation

@koen-vg
Copy link
Copy Markdown
Contributor

@koen-vg koen-vg commented Sep 18, 2024

This is necessary for the new OSM-based base network, where loaded buses already have a "country" attribute.

Closes #1306

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

Koen van Greevenbroek added 2 commits September 18, 2024 13:08
This is necessary for the new OSM-based base network, where loaded
buses already have a "country" attribute.
@koen-vg
Copy link
Copy Markdown
Contributor Author

koen-vg commented Sep 18, 2024

If I understand the intention of dropping non-OSM support correctly, the if-statement checking if "countries" is a column in buses can be simplified once OSM is the only source. I could add a note to that effect, but it seems to me like a lot of code can be simplified at that point, so hopefully that should be obvious at that point?

@fneum fneum merged commit 38f2dc7 into PyPSA:master Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Excluding certain countries is no longer possible

2 participants