Add option to reduce central heating supply temperatures annually (defaults to 1%/a)#1290
Merged
amos-schledorn merged 29 commits intomasterfrom Oct 10, 2024
Merged
Add option to reduce central heating supply temperatures annually (defaults to 1%/a)#1290amos-schledorn merged 29 commits intomasterfrom
amos-schledorn merged 29 commits intomasterfrom
Conversation
…to annual-temperature-reduction
Contributor
Validator ReportI am the Validator. Download all artifacts here. ❗ Run failed!Download 'logs' artifact to see more details.
Model Metrics Comparing |
…to annual-temperature-reduction
fneum
requested changes
Sep 24, 2024
Member
fneum
left a comment
There was a problem hiding this comment.
Looks good! Some code suggestions:
Member
|
Required config setting for transmission efficiency related to #963 |
Co-authored-by: Fabian Neumann <[email protected]>
Co-authored-by: Fabian Neumann <[email protected]>
Co-authored-by: Fabian Neumann <[email protected]>
Contributor
Author
|
@fneum thanks for the review! Addressed all comments but one (see above). Happy to make the changes, I'm fine either way. |
fneum
reviewed
Oct 10, 2024
Member
fneum
left a comment
There was a problem hiding this comment.
Great! Can merge once at least ubuntu test passes (in case I miss to do it).
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



PR #1264 updated central heating temperatures to current values based on data.
Previously, temperatures were guesstimated compromises between current and future temperatures.
This PR adds the option of decreasing temperatures (forward and return) by a fixed annual percentage (1% by default).
Changes proposed in this Pull Request
build_central_heating_temperature_profilesrule dependent onplanning_horizonswildcard`build_central_heating_profiles.runbuild_cop_profilesplanning_horizon-dependentcop_profilesinputplanning_horizon-dependent forprepare_sector_network, a)add_existing_baseyear,add_brownfield(solve_myopic),add_existing_baseyear/prepare_perfect_foresight(solve_perfect)update_heat_pump_efficiency()function to myopic/perfect foresight mode to update heat pump efficiencies of existing heat pumps in preceding yearsChecklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.Testing
This config was used:
Note: testing with perfect foresight requires deactivating the following lines in
config.default:Average forward temperatures in selected countries, with different foresight options:

Average COP:
