Skip to content

fix load weighted prices#1287

Merged
fneum merged 8 commits intomasterfrom
fix-load-weighted-prices
Nov 11, 2024
Merged

fix load weighted prices#1287
fneum merged 8 commits intomasterfrom
fix-load-weighted-prices

Conversation

@lisazeyen
Copy link
Copy Markdown
Contributor

@lisazeyen lisazeyen commented Sep 12, 2024

Changes proposed in this Pull Request

Fix bug when calculating load weighted prices in the make_summary script

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@lisazeyen lisazeyen requested a review from p-glaum September 12, 2024 13:59
@lisazeyen
Copy link
Copy Markdown
Contributor Author

@millingermarkus can you check if it is working with this branch?

@lisazeyen lisazeyen requested a review from p-glaum September 12, 2024 16:09
@lisazeyen
Copy link
Copy Markdown
Contributor Author

@p-glaum I am not dropping the prices if the load is zero at a bus.
price = price.reindex(columns=load.columns)
One could also reindex the other way around, but then the mariginal price would not be really load weighted, e.g. with
load.reindex(columns=price.columns, fill_value=1)

@p-glaum
Copy link
Copy Markdown
Contributor

p-glaum commented Sep 13, 2024

@p-glaum I am not dropping the prices if the load is zero at a bus. price = price.reindex(columns=load.columns) One could also reindex the other way around, but then the mariginal price would not be really load weighted, e.g. with load.reindex(columns=price.columns, fill_value=1)

okay, if the prices have a meaning for buses without flows going in or out, then we should definitely keep them and weight every timestep equally, i.e. with load.reindex(columns=price.columns, fill_value=1)
However, if they do not have a realistic interpretation, should we drop them?

@lisazeyen
Copy link
Copy Markdown
Contributor Author

@p-glaum I am not dropping the prices if the load is zero at a bus. price = price.reindex(columns=load.columns) One could also reindex the other way around, but then the mariginal price would not be really load weighted, e.g. with load.reindex(columns=price.columns, fill_value=1)

okay, if the prices have a meaning for buses flows going in or out, then we should definitely keep them and weight every timestep equally, i.e. wit load.reindex(columns=price.columns, fill_value=1) However, if they do not have a realistic interpretation, should we drop them?

I think if it is load weighted and the load is zero we should drop them.

@fneum
Copy link
Copy Markdown
Member

fneum commented Sep 13, 2024

I think if it is load weighted and the load is zero we should drop them.

I think equal weight would be slightly better, but dropping also ok.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 13, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: prepare_sector_network, prepare_sector_network, prepare_sector_network
  • fix-load-weighted-prices failed in: prepare_sector_network, prepare_sector_network, prepare_sector_network

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing fix-load-weighted-prices (f6f1e15) with master (834ea7f).
Branch is 8 commits ahead and 0 commits behind.
Last updated on 2024-11-10 14:50:38 CET.

@fneum fneum merged commit ee1b3d9 into master Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants