prepare_sector_network: fix e_max_pu in unsustainable biomass stores#1266
Merged
prepare_sector_network: fix e_max_pu in unsustainable biomass stores#1266
Conversation
lisazeyen
reviewed
Sep 9, 2024
| unsus_stores_idx = n.stores.loc[ | ||
| n.stores.carrier == "unsustainable solid biomass" | ||
| ].index | ||
| unsus_stores_idx = n.stores.query( |
Contributor
There was a problem hiding this comment.
unsus_stores_idx seems to be twice defined
Contributor
Author
There was a problem hiding this comment.
yes, the second definition depends on the first
cpschau
approved these changes
Sep 9, 2024
Contributor
cpschau
left a comment
cpschau
left a comment
There was a problem hiding this comment.
Good catch, thanks for cleaning up!
cpschau
reviewed
Sep 9, 2024
| unsus_stores_idx = n.stores.query( | ||
| "carrier == 'unsustainable solid biomass'" | ||
| ).index | ||
| unsus_stores_idx = unsus_stores_idx.intersection( |
Contributor
There was a problem hiding this comment.
In what cases n.stores_t.e_max_pu would not contain any columns related to the unsustainable solid biomass store?
fneum
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the time series handling of e_max_pu in for unsustainable biomass stores
Changes proposed in this Pull Request
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.