Skip to content

Approximate district heating COPs via Jensen et al. 2018#1175

Merged
lisazeyen merged 74 commits intomasterfrom
update-district-heating-cops
Aug 7, 2024
Merged

Approximate district heating COPs via Jensen et al. 2018#1175
lisazeyen merged 74 commits intomasterfrom
update-district-heating-cops

Conversation

@amos-schledorn
Copy link
Copy Markdown
Contributor

@amos-schledorn amos-schledorn commented Jul 22, 2024 •
edited by fneum
Loading

Closes #857.

with respect to central heating.

Changes proposed in this Pull Request

  • Introduce separate forward and return temperatures for district (central) heating.
  • The rule build_cop_profiles builds separate heat pump COPs for decentral and central heating.
  • The COP approximation for central heating is based on Jensen et al. 2018.
  • Additional config settings for the approximation are added, with default values partly based on Pieper et al. 2019

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

Jupyter notebook and config files are attached below (.txt must be changed accordingly).

Impact on results

A quick test run (DE only, 2 nodes, 2050) suggests the resulting COPs after changing the approximation method and forward/return temperatures in district heating to be somewhat similar as before.

Updating only the approximation method but setting an (unrealistic) forward temperature of 55C (the current default) results in significantly higher central heat pump COPs and higher heat pump investments.

image image image

jupyter_notebook.txt

config.txt

scenarios.txt

@amos-schledorn amos-schledorn marked this pull request as draft July 22, 2024 13:38
pre-commit-ci bot and others added 20 commits July 22, 2024 13:39
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
5361fac 
for more information, see https://pre-commit.ci
@amos-schledorn
Merge remote-tracking branch 'origin/master' into update-district-hea…
de10492 
…ting-cops
@amos-schledorn
update configtables
0e6a737
@amos-schledorn
use module structure
3fac27f
@amos-schledorn
change default DH return temperature to 50C
a9f4c63
@amos-schledorn
rename __main__ to run
eb2911c
@amos-schledorn
update build_sector.smk
a4847a1
@amos-schledorn
Merge remote-tracking branch 'origin/master' into update-district-hea…
b720bd9 
…ting-cops
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8d6feb6 
for more information, see https://pre-commit.ci
@amos-schledorn
remove rural/urban temperature
0c2f9b5
@amos-schledorn
Merge remote-tracking branch 'origin/update-district-heating-cops' in…
f86d94c 
…to update-district-heating-cops
@amos-schledorn
remove cop_total input from prepare_sector_network
368971f
@amos-schledorn
update base year COPs
b80bb7b
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
744aaf7 
for more information, see https://pre-commit.ci
@amos-schledorn
update inputs for add_existing_baseyear
d297f84
@amos-schledorn
udpate add_brownfield COPs
da201e1
@amos-schledorn
add licensing info
8875ab6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
64d0f29 
for more information, see https://pre-commit.ci
@amos-schledorn
Merge remote-tracking branch 'origin/master' into update-district-hea…
e216944 
…ting-cops
@amos-schledorn
update release notes
3c5b11e
@amos-schledorn amos-schledorn requested a review from fneum July 25, 2024 13:55
@amos-schledorn amos-schledorn marked this pull request as ready for review July 25, 2024 13:55
@amos-schledorn
Copy link
Copy Markdown
Contributor Author

amos-schledorn commented Jul 25, 2024

@fneum This is good to go from my side. The first CI build is failing. Any idea why?

amos-schledorn and others added 15 commits August 2, 2024 17:27
@amos-schledorn
Merge branch 'update-district-heating-cops' of https://github.com/PyP…
10e0b30 
…SA/pypsa-eur into update-district-heating-cops
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0259e06 
for more information, see https://pre-commit.ci
@amos-schledorn
update myopic mode to heat system declarations
5362c37
@amos-schledorn
Merge branch 'update-district-heating-cops' of https://github.com/PyP…
5773877 
…SA/pypsa-eur into update-district-heating-cops
@amos-schledorn
update add_existing_baseyear
390085a
@amos-schledorn
Merge remote-tracking branch 'origin/master' into update-district-hea…
7bd0c16 
…ting-cops
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
61bb225 
for more information, see https://pre-commit.ci
@amos-schledorn
update copyright notic in heatSector
f593983
@amos-schledorn
Merge branch 'update-district-heating-cops' of https://github.com/PyP…
d40ff8e 
…SA/pypsa-eur into update-district-heating-cops
@amos-schledorn
fix boiler buses for existing heating
268ff93
@amos-schledorn
update solve_perfect.add_existing_baseyear input/params
ea7fc92
@amos-schledorn
remove obsolote cop inputs from solve_perfect.add_existing_baseyear
93d60a2
@amos-schledorn
rename "enums" to "definitions" and write modules in snake case
4fe8eee
@amos-schledorn
rename "enums" to "definitions" and write modules in snake case
2e35bef
@amos-schledorn
clean up, improve docs
0e8fb80
@amos-schledorn
Copy link
Copy Markdown
Contributor Author

amos-schledorn commented Aug 6, 2024

Ready for re-review.

  • I've made some structural changes that beautify the handling of different kinds of heat systems, system types etc. as enums and moved that to a definitions module, as suggested by @lkstrp. Hope that's fine.
  • I'm getting slightly different results compared to a few days ago but I'm seeing that there were some changes in master, which I've merged into the feature that might be the reason (e.g. the clustering changed and COPs as a consequence)
  • I've also adjusted the scripts for perfect foresight and myopic mode.
  • Docs are not building but the error message is a little cryptic. Maybe @fneum, you can help?

@lisazeyen
Copy link
Copy Markdown
Contributor

lisazeyen commented Aug 7, 2024 •
edited
Loading

Ready for re-review.

  • I've made some structural changes that beautify the handling of different kinds of heat systems, system types etc. as enums and moved that to a definitions module, as suggested by @lkstrp. Hope that's fine.
  • I'm getting slightly different results compared to a few days ago but I'm seeing that there were some changes in master, which I've merged into the feature that might be the reason (e.g. the clustering changed and COPs as a consequence)
  • I've also adjusted the scripts for perfect foresight and myopic mode.
  • Docs are not building but the error message is a little cryptic. Maybe @fneum, you can help?
  • the Docs were not building through a changed syntax for the intersphinx mapping, which is unrelated to the changes in your PR, should be fixed in the master branch now.

lisazeyen
lisazeyen approved these changes Aug 7, 2024
View reviewed changes
@lisazeyen
Copy link
Copy Markdown
Contributor

lisazeyen commented Aug 7, 2024

@amosschle really nice, code looks super clean and well documented! We should use the same approach for other sectors as well.

@lisazeyen lisazeyen enabled auto-merge August 7, 2024 12:14
@lisazeyen lisazeyen disabled auto-merge August 7, 2024 12:29
@lisazeyen lisazeyen merged commit d7436a6 into master Aug 7, 2024
@amos-schledorn
Copy link
Copy Markdown
Contributor Author

amos-schledorn commented Aug 7, 2024

Note for future reference:

  • Check COP calculation of heat pumps #857 suggests using Lorenz COPs. Pieper et al. 2020 suggests an approximation via Jensen et al. (implemented in this PR) to be superior (the authors test both and other methods against a thermodynamic simulation model for a Danish district heating system
  • This PR does not touch household heat pump COPs. This is still approximated via Staffell et al. 2012. An alternative would be using values/method from the When2Heat dataset. My preliminary analysis (to be investigated further) suggests somewhat similar COP values.

fneum
fneum reviewed Aug 7, 2024
View reviewed changes
@amos-schledorn amos-schledorn mentioned this pull request Aug 26, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fneum fneum fneum requested changes

@lisazeyen lisazeyen lisazeyen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.12.0

Development

Successfully merging this pull request may close these issues.

Check COP calculation of heat pumps

3 participants

@amos-schledorn @fneum @lisazeyen