Merged
Conversation
lindnemi
pushed a commit
that referenced
this pull request
Jul 22, 2024
* impose minimum district heating progress of 0 * update release_notes * update configtables
cpschau
pushed a commit
that referenced
this pull request
Jul 26, 2024
* impose minimum district heating progress of 0 * update release_notes * update configtables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, district heating progress, i.e. the evolution between current and future district heating market share can be negative if
potentialis set to a value smaller than the current district heating market share in theconfig.Closes #1161 .
Changes proposed in this Pull Request
This PR fixes this behaviour by applying a minimum progress of 0 in
build_district_heat_share.py:diff = ((urban_fraction * central_fraction) - dist_fraction_node).clip(lower=0)Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.