Skip to content

Fix double space in existing capacities#1039

Merged
fneum merged 2 commits intoPyPSA:masterfrom
koen-vg:name-suffix-fix
Apr 25, 2024
Merged

Fix double space in existing capacities#1039
fneum merged 2 commits intoPyPSA:masterfrom
koen-vg:name-suffix-fix

Conversation

@koen-vg
Copy link
Copy Markdown
Contributor

@koen-vg koen-vg commented Apr 25, 2024

A very minor fix, but even this will surely avoid some confusion in the long run.

The name_suffix variable already includes a space after the bus name, so before this there used to be a double space after the bus name in the added capacities.

Checklist

  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in all of config.default.yaml.
  • Changes in configuration options are also documented in doc/configtables/*.csv.
  • A release note doc/release_notes.rst is added.

Koen van Greevenbroek and others added 2 commits April 25, 2024 18:05
@fneum fneum merged commit a18edcc into PyPSA:master Apr 25, 2024
@koen-vg
Copy link
Copy Markdown
Contributor Author

koen-vg commented Apr 25, 2024

Pretty sure that this pre-commit snakefmt commit is incorrect; a bit annoying cause I see snakefmt apply this change all the time. Maybe if you're quick you can still remove this from master?

Or just revert it.

Thanks also for the quick response :)

@fneum
Copy link
Copy Markdown
Member

fneum commented Apr 25, 2024

Should be okay:

In [1]: import numpy as np

In [2]: def test():
   ...:     return np.array
   ...: 

In [3]: test()([2,3,4])
Out[3]: array([2, 3, 4])

In [4]: test() ([2,3,4])
Out[4]: array([2, 3, 4])

@koen-vg
Copy link
Copy Markdown
Contributor Author

koen-vg commented Apr 25, 2024

Ah then I learned something new today! Anyway the CI is running just fine so it's in fact not a problem as you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants