Conversation
Contributor
|
I guess this actually fixes #843 too? |
fneum
approved these changes
Apr 18, 2024
Member
fneum
left a comment
There was a problem hiding this comment.
Good to go! This output is never used.
2 tasks
Member
Author
awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Suggest to remove the snakemake output for connection costs, because it creates bugs if a selection of
countriesis taken that does not contain links, andremove_stubsis set tofalse.Also,
UAis not part of the synthetic load data, so removingUAthere. I noticed theconnection_costsbug when runningUAonly which is why I'm combining those two bugfixes here.workflow tested also with config.default (all countries) for power and all other sectors.
I'm not aware of any need of the output in other rules.
Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.