Use powerplantmatching IRENASTAT for renewable capacities in add_existing_baseyear#1018
Merged
fneum merged 7 commits intoPyPSA:masterfrom Apr 30, 2024
Merged
Use powerplantmatching IRENASTAT for renewable capacities in add_existing_baseyear#1018fneum merged 7 commits intoPyPSA:masterfrom
add_existing_baseyear#1018fneum merged 7 commits intoPyPSA:masterfrom
Conversation
Member
|
I agree, @koen-vg. The link in |
Member
|
PyPSA/powerplantmatching#157 is merged and included in v0.5.13 of powerplantmatching |
fneum
approved these changes
Apr 25, 2024
Member
fneum
left a comment
There was a problem hiding this comment.
LGTM, only requires powerplantmatching version bump in environment.yaml
Needed in order to get renewable capacities from pm.IRENA newer than 2020; updated to 2023 in version 0.5.13
Contributor
Author
|
Great, easy enough to bump the version :) |
Contributor
Author
|
Guess it wasn't that easy, haha, powerplantmatching 0.5.13 will need a little bit of time until it's installable. |
Contributor
Author
|
It does now seem to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
I wanted to update existing renewable capacities to 2023 values recently made available by IRENA. But there seems to be some duplicated effort on this front within the PyPSA umbrella: powerplantmatching has information of renewable capacities from IRENA, and the same data is downloaded through a separate path in
retrieve_irena.py.As nice of an improvement #756 is, I would propose cutting out
retrieve_irena.pyaltogether and using the IRENA data retrieved by powerplantmatching directly. This is implemented in the current PR, achieving the same functionality as before with much less code all in all.To avoid a regression in terms of data for recent years, this PR should only be merged once PyPSA/powerplantmatching#157 is merged, and then should be combined with a version bump of the powerplantmatching dependency.
In the future, data on existing renewable capacities can be updated simply by updating powerplantmatching and bumping the version in pypsa-eur. This will then transparently filter through to both places where existing renewable capacities are added to network in pypsa-eur, namely in
add_electricity.pyand inadd_existing_baseyear.py. Having these two scripts depend on different sources for the same data seems like a source of confusion and potential problems.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.