Fix fill missing in industry sector ratios intermediate#1004
Merged
fneum merged 1 commit intoPyPSA:masterfrom May 20, 2024
Merged
Fix fill missing in industry sector ratios intermediate#1004fneum merged 1 commit intoPyPSA:masterfrom
fneum merged 1 commit intoPyPSA:masterfrom
Conversation
fneum
approved these changes
May 20, 2024
Member
|
Good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
I found a strange behaviour of
build_industry_sector_ratios_intermediate. When looking to intermediate steps between current and futur industry, missing values were wrongly filled with futur data.I suggest to use futur data only when we miss the full description of the technology (carrier whise).
Here is an example of Ammonia in Belgium where we see a mix of current and futur data.
I used to following values for
sector_ratios_fraction_future:Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.doc/release_notes.rstis added.