address all-zero time-dependent value removal bug (closes #722)#734
address all-zero time-dependent value removal bug (closes #722)#734
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 77.92% 77.88% -0.04%
==========================================
Files 26 26
Lines 6795 6793 -2
Branches 1479 1478 -1
==========================================
- Hits 5295 5291 -4
- Misses 1182 1185 +3
+ Partials 318 317 -1
☔ View full report in Codecov by Sentry. |
|
Fixes #722 |
|
I agree this makes sense for the netcdf representation, where there is compression (which is now enabled by default), but there are other exporters like to csv where this has a big impact (not only in storage space, but also in file space, which incidentally is also where this branch was originally implemented and included into the exporter/importer infrastructure). Yes the interaction with optional attributes like (Moved here from issue) |
Still have to check how much it affects file size.