Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
- Coverage 76.54% 76.45% -0.09%
==========================================
Files 24 24
Lines 6258 6257 -1
Branches 1336 1337 +1
==========================================
- Hits 4790 4784 -6
- Misses 1186 1188 +2
- Partials 282 285 +3
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
FabianHofmann
approved these changes
Mar 31, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #552.
Changes proposed in this Pull Request
Implements unit commitment constraints for Link component in non-pyomo interfaces.
For
native, a little generalisation of the UC variable/constraint definition was necessaryFor
linopy, actually no modifications are necessary except for adding the corresponding attributes to the Link component.bus0, so one cannot simply copy attributes from Generator to Link for equivalent results, but I think that makes sense.[ ] Linopf.py does not have start_up_cost and shut_down_cost when calculating UC problem. #438 should be tackled for this PR to make senseChecklist
doc.[] Newly introduced dependencies are added toenvironment.yaml,environment_docs.yamlandsetup.py(if applicable).doc/release_notes.rstof the upcoming release is included.