fix: properly assign controllable branches#1578
Merged
FabianHofmann merged 2 commits intomasterfrom Feb 24, 2026
Merged
Conversation
Member
|
Good catch! But where is my release note, this is still fixing/ changing directly exposed behavior And these days we would even add a test for that |
Contributor
Author
I have to remind myself that the days of lazy one-liner PRs are officially over. it is actually tested by the doc test. could of course be better with checking the first level index against |
Contributor
Author
|
fine if I append the release note in #1333? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quite some bug, but nothing severe (hopefully downstream too)