fix: ramp limit contstraints failing because of mismatched index#1537
Merged
lkstrp merged 3 commits intoPyPSA:masterfrom Jan 26, 2026
Merged
fix: ramp limit contstraints failing because of mismatched index#1537lkstrp merged 3 commits intoPyPSA:masterfrom
lkstrp merged 3 commits intoPyPSA:masterfrom
Conversation
Irieo
approved these changes
Jan 23, 2026
Contributor
Irieo
left a comment
Irieo
left a comment
There was a problem hiding this comment.
This fixes the problem, and much cleaner implementation.
I am surprised we were missing this simple test for combination of multi-period investments + ramp limits.
I've looked through the rest of constraints code, this was the only place with the problematic .reindex() pattern.
|
This change works for me as well. Thank you for the continued support. |
|
Hi, I manually applied these changes to my code, and it worked. Just now waiting for the checks to be completed so that I can request others to merge with this latest release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1517
Checklist
docs.docs/release-notes.mdof the upcoming release is included.