import series only if not empty for oneport components#1528
Merged
lkstrp merged 6 commits intoPyPSA:masterfrom Feb 5, 2026
Merged
import series only if not empty for oneport components#1528lkstrp merged 6 commits intoPyPSA:masterfrom
lkstrp merged 6 commits intoPyPSA:masterfrom
Conversation
lkstrp
approved these changes
Jan 27, 2026
Member
lkstrp
left a comment
There was a problem hiding this comment.
Thanks @yerbol-akhmetov !
Could you add a minimal test and release notes for this as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Good day. I was working with PyPSA and noticed that
get_clustering_from_busmapfunction that are used in PyPSA-Eur and PyPSA-Earth makes the clustered network have timeseries for storage units filled with default. As a result, it was not possible to useaggregateoneportfunction again after clustering, because timeseries were not empty. Currently,get_clustering_from_busmapdo not import empty timeseries for generators, links, and lines. However, for one port components likestorage_unitswe have empty timeseries added with_import_series_from_dfmethod, which fills missing inputs with defaults. Forp, it is 0. It might be a not a huge problem, because after clustering in PyPSA-X we have exporting to netcdf, which cleans up default timeseries data. But it seems not convenient if you would like to do further manipulations with clustered network.Is it intentional? Or we can keep one port components consistent with others and include
if not df.empty? What do you think @lkstrp?Checklist
docs.docs/release-notes.mdof the upcoming release is included.