fix: netcdf export corrupting dynamic attributes when directly assigning df#1522
Merged
lkstrp merged 4 commits intoPyPSA:masterfrom Jan 13, 2026
Merged
fix: netcdf export corrupting dynamic attributes when directly assigning df#1522lkstrp merged 4 commits intoPyPSA:masterfrom
lkstrp merged 4 commits intoPyPSA:masterfrom
Conversation
| assert status == "ok" | ||
|
|
||
|
|
||
| def test_1522(tmp_path): |
Contributor
There was a problem hiding this comment.
I am not a huge fan of numbered tests, is that good practice? mostly asking for future purposes
Member
There was a problem hiding this comment.
I don't have strong feelings. Certainly good to keep the reference to the issue, but could be in docstring.
Member
Author
There was a problem hiding this comment.
Ah sorry, that was a quick merge. I guess it's just a matter of style and builds on what we already have. When a test is specifically designed to test a bug, it's better to add it here rather than bloating the normal tests. But we don't need to name them test_xx, so let's keep those in test_bugs.py, but without numbered test names in future
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1521
This should also be catched and sanitized upfront with #1487. Also cleaning up how we store to netcdf would help