fix: using inactive generators in global carrier constraint#1450
fix: using inactive generators in global carrier constraint#1450lkstrp merged 6 commits intoPyPSA:masterfrom
Conversation
FabianHofmann
left a comment
There was a problem hiding this comment.
We are not fully there yet. The stores are missing in the filtering. also the investment periods are not considered in the filtering process. For multi-invest problems this will now only filter based on the static active columns. I would push provide a small fix for that, if you agree?
- Add filter_active() supporting DataFrame and Index filtering - Support single/multiple investment periods for multi-invest - Simplify global_constraints.py using new method - Fix missing active filtering for stores in primary_energy_limit
24c5dfe to
f1400c2
Compare
|
Thanks for adding @FabianHofmann ! You are right, it's also cleaner to add a dedicated method for it. I would just further move it around. We now have |
|
sure thing! you are right about the three parallel methods (forgot about
I like that, will do that |
- Rename method to better distinguish from get_active_assets - Make data parameter required (remove self.static default) - Update all usages in global_constraints.py
Closes #1449
Checklist
docs.docs/release-notes.mdof the upcoming release is included.