Fix handling of inactive storage components in constraints/variables#1442
Merged
Fix handling of inactive storage components in constraints/variables#1442
Conversation
lkstrp
approved these changes
Nov 17, 2025
a-buntjer
pushed a commit
to a-buntjer/PyPSA
that referenced
this pull request
Nov 27, 2025
Merged changes from PyPSA v1.0.3 and v1.0.4 including: - Fix busmap clustering for multilinks (PyPSA#1441) - Fix handling of inactive storage components (PyPSA#1442) - Fix masking of nan constraints in kvl (PyPSA#1438) - Fix snapshot selection for operational in multi period (PyPSA#1437) - Fix ramping-/rolling horizon logic (PyPSA#1428) - CI improvements and dependency updates Resolved conflicts in pypsa/optimization/constraints.py: - Used upstream's c.active_assets approach (cleaner, already handles MultiIndex) - Preserved our stochastic Store constraint fix (transpose for dimension alignment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1440
Changes proposed in this Pull Request
This PR fixes two problems related to active/inactive attr handling. First was connected to xarray alignment error when some storage components have active=False due to unfiltered data arrays being combined with filtered variables. Second was connected to spillage variable fail when all StorageUnits are inactive due to empty array issue.
Thanks @SpamAndEgg for spotting these.
Checklist
docs.docs/release-notes.mdof the upcoming release is included.