fix: masking of nan constraints in kvl#1438
Merged
Conversation
lkstrp
approved these changes
Nov 12, 2025
Member
lkstrp
left a comment
lkstrp
left a comment
There was a problem hiding this comment.
Ah, it can be simple as that! thanks a lot @FabianHofmann !
I wasn't sure if we had more nans set, which linopy had previously handled for PyPSA. But you're right, it's better to be strict and fix it here
Contributor
Author
|
@lkstrp sure thing! should I also fix the unrelated doc test here which seems to be related to a missing carrier in one example? |
Member
|
All good, I will fix it. Wanna check if we can unpin |
fneum
approved these changes
Nov 12, 2025
a-buntjer
pushed a commit
to a-buntjer/PyPSA
that referenced
this pull request
Nov 27, 2025
Merged changes from PyPSA v1.0.3 and v1.0.4 including: - Fix busmap clustering for multilinks (PyPSA#1441) - Fix handling of inactive storage components (PyPSA#1442) - Fix masking of nan constraints in kvl (PyPSA#1438) - Fix snapshot selection for operational in multi period (PyPSA#1437) - Fix ramping-/rolling horizon logic (PyPSA#1428) - CI improvements and dependency updates Resolved conflicts in pypsa/optimization/constraints.py: - Used upstream's c.active_assets approach (cleaner, already handles MultiIndex) - Preserved our stochastic Store constraint fix (transpose for dimension alignment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Apply KVL masking and bump linopy version.
@lkstrp @Irieo the "problem" with the new linopy version (and yes it should have been version 0.6.0) is that it checks more rigorously on the constraints sanity. PyPSA's KVL constraint had nan's in the right hand side for a subset of constraints. These result from different sets of active branches across the periods. Having nan rhs values is formally incorrect, so linopy raising an error is what we want here. I have added a mask which filters out the unwanted constraints on the linopy side.
So PyPSA/linopy#520 is not needed and I still need to think about whether we want to have it in.
Checklist
docs.docs/release-notes.mdof the upcoming release is included.