fix: snapshot selection for operational in multi period optimization#1437
Merged
fix: snapshot selection for operational in multi period optimization#1437
Conversation
Contributor
|
@FabianHofmann I made a small problem instance trying to understand/recreate the bug and realised that (i) bug was indeed there and (ii) the fix was incomplete because period weightings had the same problem (mismatch between global and investment period index). So I append the fix and add unit test for that. |
Irieo
approved these changes
Nov 11, 2025
Contributor
Irieo
left a comment
Irieo
left a comment
There was a problem hiding this comment.
See my comment in PR discussion.
lkstrp
approved these changes
Nov 12, 2025
Contributor
Author
awesome! thanks @Irieo ! |
a-buntjer
pushed a commit
to a-buntjer/PyPSA
that referenced
this pull request
Nov 27, 2025
Merged changes from PyPSA v1.0.3 and v1.0.4 including: - Fix busmap clustering for multilinks (PyPSA#1441) - Fix handling of inactive storage components (PyPSA#1442) - Fix masking of nan constraints in kvl (PyPSA#1438) - Fix snapshot selection for operational in multi period (PyPSA#1437) - Fix ramping-/rolling horizon logic (PyPSA#1428) - CI improvements and dependency updates Resolved conflicts in pypsa/optimization/constraints.py: - Used upstream's c.active_assets approach (cleaner, already handles MultiIndex) - Preserved our stochastic Store constraint fix (transpose for dimension alignment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the wrong selection of last snapshot per period in case of investment period selection on operational limit constraint
Changes proposed in this Pull Request
Checklist
docs.docs/release-notes.mdof the upcoming release is included.