Conversation
Contributor
Author
|
🟢 |
Contributor
|
Just stumbled over this bug, and there comes the fix 😇 Thanks @Irieo |
a-buntjer
pushed a commit
to a-buntjer/PyPSA
that referenced
this pull request
Nov 27, 2025
Merged changes from PyPSA v1.0.3 and v1.0.4 including: - Fix busmap clustering for multilinks (PyPSA#1441) - Fix handling of inactive storage components (PyPSA#1442) - Fix masking of nan constraints in kvl (PyPSA#1438) - Fix snapshot selection for operational in multi period (PyPSA#1437) - Fix ramping-/rolling horizon logic (PyPSA#1428) - CI improvements and dependency updates Resolved conflicts in pypsa/optimization/constraints.py: - Used upstream's c.active_assets approach (cleaner, already handles MultiIndex) - Preserved our stochastic Store constraint fix (transpose for dimension alignment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1424
Changes proposed in this Pull Request
This PR fixes several issues we have in ramping constraints. Citing @lkstrp, it is another case of our very annoying
p == p0 but != p0the original point was whether
p0here is redundant:PyPSA/pypsa/optimization/constraints.py
Line 608 in 6f70f53
A: No. Although during optimization it indeed
-p(dynamic attributep0does not exist at point of optimization and is created after solve inassign_solution). However, there is a case whendefine_ramp_limit_constraintsis applied in rolling horizon mode. In this case we have to refer to previous period's dispatch (stored inp0for a Link specifically).Checklist
docs.docs/release-notes.mdof the upcoming release is included.