Conversation
lkstrp
approved these changes
Oct 9, 2025
lkstrp
pushed a commit
that referenced
this pull request
Oct 13, 2025
lkstrp
pushed a commit
that referenced
this pull request
Oct 13, 2025
lkstrp
pushed a commit
that referenced
this pull request
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with failing tests in stochastic optimization test suite.
The problem was introduced in 15eeffc ("clustering user guide") where the commit removes the local annuity(lifetime, r) helper function and replaced it with pypsa.community.annuity() but does not swap the argument order. The local function signature was (lifetime, rate) but the pypsa.common.annuity has (rate, lifetime).
this wasn't easy to find where this problem in v1-docs history I must admit 🧙♂️