Skip to content

feat: add system_cost method to calculate total system cost from capital and operational expenditures#1183

Merged
lkstrp merged 12 commits intomasterfrom
fneum/tsc-stats
Apr 8, 2025
Merged

feat: add system_cost method to calculate total system cost from capital and operational expenditures#1183
lkstrp merged 12 commits intomasterfrom
fneum/tsc-stats

Conversation

@fneum
Copy link
Copy Markdown
Member

@fneum fneum commented Mar 21, 2025

Changes proposed in this Pull Request

Add statistic n.statistics.system_cost() that is the sum of n.statistics.opex() + n.statistics.capex(). Will be useful with #1156

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@fneum fneum requested a review from lkstrp March 21, 2025 13:18
Copy link
Copy Markdown
Contributor

@FabianHofmann FabianHofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note that the system cost would also include start up and shut down costs.

@fneum
Copy link
Copy Markdown
Member Author

fneum commented Mar 21, 2025

Ah, you're right. But I think they should then be included in opex.

Copy link
Copy Markdown
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add it to the docs as well? Even if they show the wrong docstring right now.

@lkstrp lkstrp mentioned this pull request Mar 24, 2025
21 tasks
@fneum
Copy link
Copy Markdown
Member Author

fneum commented Mar 31, 2025

@FabianHofmann's comment is addressed via #1195

@lkstrp lkstrp enabled auto-merge (squash) April 8, 2025 12:02
@lkstrp lkstrp merged commit 5d78af5 into master Apr 8, 2025
22 checks passed
@lkstrp lkstrp deleted the fneum/tsc-stats branch April 8, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants