distributed slack implementation#107
Merged
FabianHofmann merged 17 commits intomasterfrom Nov 25, 2019
Merged
Conversation
Contributor
|
looks good (but not tested), I would replace all |
Contributor
|
you mind if I push a commit which removes unnecessary imports? (btw it seems that the function |
Member
Author
|
Member
Author
|
Found the remaining deprecation warnings for |
Contributor
yes, looks good. They appear when running |
Contributor
|
mmh, okay solving the collections deprecation warning isn't compatible with python2.7, another reason to drop the support. I'll revert it for the moment |
environment: Specify six version setup.py: Specify six version and fix pandas version
6 tasks
1 task
fneum
pushed a commit
that referenced
this pull request
Mar 20, 2022
* rewrite mocksnakemake for parsing real Snakefile * continue add function to scripts * going through all scripts, setting new mocksnakemake * fix plotting scripts * fix build_country_flh * fix build_country_flh II * adjust config files * fix make_summary for tutorial network * create dir also for output * incorporate suggestions * consistent import of mocksnakemake * consistent import of mocksnakemake II * Update scripts/_helpers.py Co-Authored-By: euronion <[email protected]> * Update scripts/_helpers.py Co-Authored-By: euronion <[email protected]> * Update scripts/_helpers.py Co-Authored-By: euronion <[email protected]> * Update scripts/_helpers.py Co-Authored-By: euronion <[email protected]> * Update scripts/plot_network.py Co-Authored-By: euronion <[email protected]> * Update scripts/plot_network.py Co-Authored-By: euronion <[email protected]> * Update scripts/retrieve_databundle.py Co-Authored-By: euronion <[email protected]> * use pathlib for mocksnakemake * rename mocksnakemake into mock_snakemake * revert change in data * Update scripts/_helpers.py Co-Authored-By: euronion <[email protected]> * remove setting logfile in mock_snakemake, use Path in configure_logging * fix fallback path and base_dir fix return type of make_io_accessable * reformulate mock_snakemake * incorporate suggestion, fix typos * mock_snakemake: apply absolute paths again, add assertion error *.py: make hard coded io path accessable for mock_snakemake * retrieve_natura_raster: use snakemake.output for fn_out * include suggestion * Apply suggestions from code review Co-Authored-By: Jonas Hörsch <[email protected]> * linting, add return ad end of file * Update scripts/plot_p_nom_max.py Co-Authored-By: Jonas Hörsch <[email protected]> * Update scripts/plot_p_nom_max.py fixes #112 Co-Authored-By: Jonas Hörsch <[email protected]> * plot_p_nom_max: small correction * config.tutorial.yaml fix snapshots end * use techs instead of technology * revert try out from previous commit, complete replacing * change clusters -> clusts in plot_p_nom_max due to wildcard constraints of clusters * change clusters -> clusts in plot_p_nom_max due to wildcard constraints of clusters II
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10
Adds an option
distribute_slacktoto distribute the total slack power to all generators proportional to their dispatch at the respective snapshot.
Docstrings already extended.
@anileinchen, could you please also test this?
Remaining TODOs: