Skip to content

add 4 kA high-temperature low-sag (HTLS) line type#1046

Merged
fneum merged 2 commits intomasterfrom
htls
Sep 26, 2024
Merged

add 4 kA high-temperature low-sag (HTLS) line type#1046
fneum merged 2 commits intomasterfrom
htls

Conversation

@nworbmot
Copy link
Copy Markdown
Member

@nworbmot nworbmot commented Sep 25, 2024

Based on data from JAO Static Grid Model.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

Based on data from JAO Static Grid Model.
@bobbyxng
Copy link
Copy Markdown
Contributor

bobbyxng commented Sep 25, 2024

Based on data from JAO Static Grid Model.

Checklist

* [x]  Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in `doc`.

* [ ]  Unit tests for new features were added (if applicable).

* [ ]  A note for the release notes `doc/release_notes.rst` of the upcoming release is included.

* [x]  I consent to the release of this PR's code under the MIT license.

I come to the same values based on JAO's static grid model data, so it looks fine to me!
I further updated the user-guide with a reference to JAO.

Edit:// Not super certain on what a good assumption might be on the cross-section, @p-glaum @nworbmot what do you think?

Copy link
Copy Markdown
Contributor

@bobbyxng bobbyxng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fneum fneum merged commit 20aa422 into master Sep 26, 2024
cpschau pushed a commit to cpschau/PyPSA that referenced this pull request Sep 27, 2024
* add 4 kA high-temperature low-sag (HTLS) line type

Based on data from JAO Static Grid Model.

* Updated description in the user-guide: components.rst.

---------

Co-authored-by: bobbyxng <[email protected]>
lkstrp added a commit that referenced this pull request Oct 1, 2024
* draft generator constraint

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* extension by p_sum_min and p_sum_max

* refactor: introduce naming conventions (#1028)

* refactor: naming convention `network` -> `n`

* refactor: naming `sub_network` and `sub-network`

* refactor: naming `df` -> `static`

* refactor: naming `dataframe` -> `df`

* refactor: naming `pnl` -> `dynamic`

* ignore linopy in type checking

* docs: add release notes

* fix: pre-commit

* make dataclasses more robust

* fix: missed pnl

* fix docs

* add some more deprecation decorators

* fix type ignore

* add 4 kA high-temperature low-sag (HTLS) line type (#1046)

* add 4 kA high-temperature low-sag (HTLS) line type

Based on data from JAO Static Grid Model.

* Updated description in the user-guide: components.rst.

---------

Co-authored-by: bobbyxng <[email protected]>

* changed attribute name from p_sum to e_sum; added consistency check; added docstrings

* rename constraint function; add tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Lukas Trippe <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add test with snapshots

* docstring and indexing

* resolve comments

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lukas Trippe <[email protected]>
Co-authored-by: Tom Brown <[email protected]>
Co-authored-by: bobbyxng <[email protected]>
@lkstrp lkstrp deleted the htls branch December 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants