Stochastic Network: refactor and add tests#1040
Merged
Irieo merged 5 commits intostoch_pypsafrom Sep 24, 2024
Merged
Conversation
Irieo
reviewed
Sep 24, 2024
| ) | ||
| min_pu = pd.DataFrame(0, *max_pu.axes) | ||
| if attr == "state_of_charge": | ||
| max_pu = self.get_switchable_as_dense(c, "max_hours", sns, inds=index) |
Contributor
There was a problem hiding this comment.
@FabianHofmann for state_of_charge case this line does not work since
sn.pnl(component).keys() does not contain max_hours attr.
we can (i) roll back to my workaround, or (ii) more generally, make get_stichable_as_dense handle such cases.
go for the latter?
Contributor
Author
There was a problem hiding this comment.
yes, let's go for the latter. I'll push a commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.