Intended behavior of global constraint "define_operational_limit"? #1024
Description
Version Checks (indicate both or one)
-
I have confirmed this bug exists on the lastest release of PyPSA.
-
I have confirmed this bug exists on the current
masterbranch of PyPSA.
Issue Description
In the global constraint for the operational limit, for stores we do not consider the carrier of the store itself, but the carrier of the bus the store is attached to.
PyPSA/pypsa/optimization/global_constraints.py
Lines 372 to 375 in b1567f7
For generators and storage_units, however, we consider the carrier of the generator/storage_unit and not of the bus it is attached to.
PyPSA/pypsa/optimization/global_constraints.py
Lines 354 to 369 in b1567f7
Not sure if this is wanted. In the documentation about Stores, it just says the carrier is the carrier of the store, but it does not say that this has to have the same carrier as the bus carrier.
I think I would change the way, how the global constraint is defined for the stores that, similarly to the generators, we just look at the carrier of the store instead of the bus carrier. On the other hand, I am not sure whether this change would break anything else or might be a breaking change for some people.
Reproducible Example
No response
Expected Behavior
No response
Installed Versions
Details
Replace this line.